feat: exchange Metal API keys for LB API OAuth2 tokens #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
force-pushed
the
emlb-oauth
branch
from
074530d to
dd0453d
Compare
ctreatma
commented
Sep 27, 2023
ctreatma
commented
Sep 28, 2023
displague
reviewed
Sep 28, 2023
displague
reviewed
Sep 28, 2023
ctreatma
commented
Sep 28, 2023
ctreatma
commented
Sep 28, 2023
ctreatma
commented
Sep 28, 2023
metal/loadbalancers/emlb/emlb.go
Outdated
| return err | ||
| } | ||
|
|
||
| // 3. Add the annotations |
There was a problem hiding this comment.
- ID of the load balancer
- Name of the load balancer
- Metro of the load balancer
- IP address of the load balancer
- Listener port that this service is using
ctreatma
commented
Sep 28, 2023
ctreatma
commented
Sep 28, 2023
ctreatma
commented
Sep 28, 2023
ctreatma
commented
Sep 28, 2023
ctreatma
force-pushed
the
emlb-oauth
branch
from
ea0baa9 to
2190307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
oauth2.TokenSourcethat uses the token exchange endpoint to request an OAuth2 JWT for the given API key.The
TokenSourceis added to the context under thelbaas.ContextOAuth2context key. The load balancer API client automatically looks for aTokenSourceunder that key, uses it to get the OAuth2 token, and adds the token to outgoing requests.